Hi! I discovered that IRC control codes are not working in SyncTerm. Can you or someone else fix this or direct me to the source code so we can update it? I tested using BogusTrivia. The control codes show up fine when connected IrcCloud but not in SyncTerm, where they show up as hearts and other strange symbols. Thanks!

---
þ Synchronet þ The Realm BBS

Re: SyncTerm and IRC
By: NeoArata to Cyan on Sat Mar 05 2022 08:29 am

Hi! I discovered that IRC control codes are not working in SyncTerm. Can you or someone else fix this or direct me to the source code so we can update it?
I tested using BogusTrivia. The control codes show up fine when connected IrcCloud but not in SyncTerm, where they show up as hearts and other strange symbols. Thanks!

That doesn't sound like a SyncTERM issue. Did you try with other native BBS clients (e.g. Netrunner)? I suspect you'd see the same result.
--
digital man (rob)

Rush quote #67:
He's noble enough to win the world, but weak enough to lose it .. New World Man Norco, CA WX: 54.5øF, 55.0% humidity, 4 mph E wind, 0.00 inches rain/24hrs
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: SyncTerm and IRC
By: NeoArata to Cyan on Sat Mar 05 2022 08:29:21

Hi! I discovered that IRC control codes are not working in SyncTerm. Can you or someone else fix this or direct me to the source code so we can update it? I tested using BogusTrivia. The control codes show up fine when connected IrcCloud but not in SyncTerm, where they show up as hearts and other strange symbols. Thanks!

If you're using the IRC client that comes with Synchronet, then the place to fix this would be in exec/irc.js. You'd need to find every place it writes a string to the terminal, and replace any control/color codes in the string with something more appropriate (eg. an equivalent CTRL-A code).

You'd see the same problem in any terminal, and that's as it should be. The terminal doesn't know that it's being used for IRC, and it might be used for other things where those codes have a totally different meaning.

---
echicken
electronic chicken bbs - bbs.electronicchicken.com
---
þ Synchronet þ electronic chicken bbs - bbs.electronicchicken.com

Re: SyncTerm and IRC
By: echicken to NeoArata on Sun Mar 06 2022 03:28 am

Re: SyncTerm and IRC

hearts and other strange symbols. Thanks!

If you're using the IRC client that comes with Synchronet, then the place to fix this would be in exec/irc.js. You'd need to find every place it writes a string to the terminal, and replace any control/color codes in the string with something more appropriate (eg. an equivalent CTRL-A code).

You'd see the same problem in any terminal, and that's as it should be. The terminal doesn't know that it's being used for IRC, and it might be used for other things where those codes have a totally different meaning.

Thanks. I'll take a look. However, why would it work properly in the IRCCloud client if it isn't a SyncTerm issue? Since it works in IRCCloud, that tells me the server is sending the correct control code and the client isn't interpreting it correctly.

---
þ Synchronet þ The Realm BBS

Re: SyncTerm and IRC
By: echicken to NeoArata on Sun Mar 06 2022 03:28 am

If you're using the IRC client that comes with Synchronet, then the place to fix this would be in exec/irc.js. You'd need to find every place it writes a string to the terminal, and replace any control/color codes in the string with something more appropriate (eg. an equivalent CTRL-A code).

I managed to fix the issue. You were correct that it was in irc.js Should I create a PR?

---
þ Synchronet þ The Realm BBS

Re: SyncTerm and IRC
By: NeoArata to echicken on Sun Mar 06 2022 08:12 am

Re: SyncTerm and IRC
By: echicken to NeoArata on Sun Mar 06 2022 03:28 am

Re: SyncTerm and IRC

hearts and other strange symbols. Thanks!

If you're using the IRC client that comes with Synchronet, then the place to fix this would be in exec/irc.js. You'd need to find every place it writes a string to the terminal, and replace any control/color codes in the string with something more appropriate (eg. an equivalent CTRL-A code).

You'd see the same problem in any terminal, and that's as it should be. The terminal doesn't know that it's being used for IRC, and it might be used for other things where those codes have a totally different meaning.

Thanks. I'll take a look. However, why would it work properly in the IRCCloud client if it isn't a SyncTerm issue? Since it works in IRCCloud, that tells me the server is sending the correct control code and the client isn't interpreting it correctly.

You're comparing a BBS terminal/client with an IRC client. They're 2 different things conforming to different sets of standards. If you're running an IRC client from within SyncTERM (e.g. you're connected to a BBS which has an IRC client that you're using), then it would be *that* IRC client that would need to do this IRC color code interpretation, not the terminal.
--
digital man (rob)

Breaking Bad quote #48:
I am not in danger, Skyler. I am the danger. - Walter White
Norco, CA WX: 60.4øF, 44.0% humidity, 0 mph ESE wind, 0.00 inches rain/24hrs ---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: SyncTerm and IRC
By: NeoArata to echicken on Sun Mar 06 2022 11:29:22

I managed to fix the issue. You were correct that it was in irc.js Should I create a PR?

Sure, go for it.

My advice wasn't well-considered so it'd be good to give this a little bit of thought and review before merging. (ie. is it smart/safe to translate color codes in *every* string that gets written to the terminal? Probably, but I dunno.)

---
echicken
electronic chicken bbs - bbs.electronicchicken.com
---
þ Synchronet þ electronic chicken bbs - bbs.electronicchicken.com