open https://gitlab.synchro.net/main/sbbs/-/issues/412

I'm not even sure how to describe this so I'm going to do a video. Essentially, when clicking on a menu hotspot, junk from the mouseclick is sent, causing the program that was called to run then exit.

https://www.dropbox.com/s/cebs5xelosjeg2p/SyncTERM%20-%20%28AC%29%20EOTL%202022-06-21%2012-39-31.mp4?dl=0

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/issues/412#note_2636

Please attach the menu file(s) in question. They control what is sent as input upon a mouse click (and where the mouse hotspots area).

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/issues/412#note_2638

Since gitlab wont accept .asc files, I've just uploaded them to vert: eotl_email.asc eotl_forums.asc
Yes, I could rename them, but also giblab could accept them :)

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/issues/412#note_2639

In my email section if I click S to send, then I get this in the log

Jun 22 00:59:16 bbs synchronet: term Node 1 <Nelgin> SGR Mouse button-click (0x00) reported at: 9 x 11
Jun 22 00:59:16 bbs synchronet: term Node 1 <Nelgin> Stuffing hot spot command into keybuf: 'S'
Jun 22 00:59:16 bbs synchronet: term Node 1 <Nelgin> append key into keybuf: 53 (S)
Jun 22 00:59:16 bbs synchronet: term Node 1 <Nelgin> Executing external: ?/sbbs/xtrn/addressbook/addressbook.js
Jun 22 00:59:16 bbs synchronet: term Node 1 <Nelgin> SGR Mouse button-click (0x00) reported at: 9 x 11
Jun 22 00:59:16 bbs synchronet: term Node 1 <Nelgin> Eating SGR mouse report: 'ESC[<0;10;12m'


However if I go with R to read
Jun 22 00:59:37 bbs synchronet: term Node 1 <Nelgin> SGR Mouse button-click (0x00) reported at: 45 x 11
Jun 22 00:59:37 bbs synchronet: term Node 1 <Nelgin> Stuffing hot spot command into keybuf: 'R'
Jun 22 00:59:37 bbs synchronet: term Node 1 <Nelgin> append key into keybuf: 52 (R)
Jun 22 00:59:37 bbs synchronet: term Node 1 <Nelgin> Executing external: ?../xtrn/DDMsgReader/DDMsgReader.js 0 1 0
Jun 22 00:59:38 bbs synchronet: term Node 1 <Nelgin> Scrolled 6 mouse hot-spots 1 rows (6 remain)
Jun 22 00:59:38 bbs synchronet: term Node 1 <Nelgin> insert key into keybuf: 3C (<)
Jun 22 00:59:38 bbs synchronet: term Node 1 <Nelgin> insert key into keybuf: 5B ([)

rather than eating the mouse input, it's scrolling the mouse and pasting characters into the buffer.


case 'R': // Read your mail
bbs.read_mail(MAIL_YOUR, user.number);
break;

case 'S': // Send Mail
case 'N': // Send Mail
bbs.exec("?/sbbs/xtrn/addressbook/addressbook.js");
break;

One is using the built in bbs.read_mail which will eventually go off and call DDMsgReader.js the other is a direct bbs.exec which seems to work fine in this instance.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/issues/412#note_2640

[attrtest.asc](/uploads/71c9c21976253b2f3a9dfccbe2ea0c28/attrtest.asc) Attaching a .asc file as a test.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/issues/412#note_2641

My bad, I just saw the "click to upload" link. :) Now I see "Attach a file" at the bottom.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/issues/412#note_2642

[eotl_email.asc](/uploads/39951df77d1e283105772c7a1ef521e0/eotl_email.asc)

[eotl_forums.asc](/uploads/56b66803ae524120b1e1d9eeec175253/eotl_forums.asc)

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/issues/412#note_2645

I wrote a simple script to just display one of your problem files and log the keys (characters) sent from the client/terminal:

```
while(bbs.online) {
console.printfile("eotl_email.asc");
var key = console.getkey();
log("Key = " + key);
if(key == 'Q')
break;
}
```

The results look normal/as-expected. Note: I did add "PRESS" versus "RELEASE" detail to the mouse-related debug log output. I see no problem:

```
6/25 06:40:48p Node 1 <Digital Man> SGR Mouse button (0x00) PRESS reported at: 45 x 11
6/25 06:40:48p Node 1 <Digital Man> Stuffing hot spot command into keybuf: 'R'
6/25 06:40:48p Node 1 <Digital Man> append key into keybuf: 52 (R)
6/25 06:40:48p Node 1 <Digital Man> Key = R
6/25 06:40:48p Node 1 <Digital Man> SGR Mouse button (0x00) RELEASE reported at: 45 x 11
6/25 06:40:48p Node 1 <Digital Man> Eating SGR mouse report: 'ESC[<0;46;12m'
6/25 06:40:56p Node 1 <Digital Man> SGR Mouse button (0x00) PRESS reported at: 9 x 11
6/25 06:40:56p Node 1 <Digital Man> Stuffing hot spot command into keybuf: 'S'
6/25 06:40:56p Node 1 <Digital Man> append key into keybuf: 53 (S)
6/25 06:40:56p Node 1 <Digital Man> Key = S
6/25 06:40:56p Node 1 <Digital Man> SGR Mouse button (0x00) RELEASE reported at: 9 x 11
6/25 06:40:56p Node 1 <Digital Man> Eating SGR mouse report: 'ESC[<0;10;12m'
6/25 06:41:03p Node 1 <Digital Man> SGR Mouse button (0x00) PRESS reported at: 45 x 11
6/25 06:41:03p Node 1 <Digital Man> Stuffing hot spot command into keybuf: 'R'
6/25 06:41:03p Node 1 <Digital Man> append key into keybuf: 52 (R)
6/25 06:41:03p Node 1 <Digital Man> Key = R
6/25 06:41:03p Node 1 <Digital Man> SGR Mouse button (0x00) RELEASE reported at: 45 x 11
6/25 06:41:03p Node 1 <Digital Man> Eating SGR mouse report: 'ESC[<0;46;12m'
6/25 06:41:04p Node 1 <Digital Man> SGR Mouse button (0x00) PRESS reported at: 45 x 12
6/25 06:41:04p Node 1 <Digital Man> Stuffing hot spot command into keybuf: 'U'
6/25 06:41:04p Node 1 <Digital Man> append key into keybuf: 55 (U)
6/25 06:41:04p Node 1 <Digital Man> Key = U
6/25 06:41:04p Node 1 <Digital Man> SGR Mouse button (0x00) RELEASE reported at: 45 x 12
6/25 06:41:04p Node 1 <Digital Man> Eating SGR mouse report: 'ESC[<0;46;13m'
6/25 06:41:06p Node 1 <Digital Man> SGR Mouse button (0x00) PRESS reported at: 9 x 14
6/25 06:41:06p Node 1 <Digital Man> Stuffing hot spot command into keybuf: 'F'
6/25 06:41:06p Node 1 <Digital Man> append key into keybuf: 46 (F)
6/25 06:41:06p Node 1 <Digital Man> Key = F
6/25 06:41:06p Node 1 <Digital Man> SGR Mouse button (0x00) RELEASE reported at: 9 x 14
6/25 06:41:06p Node 1 <Digital Man> Eating SGR mouse report: 'ESC[<0;10;15m'
6/25 06:41:08p Node 1 <Digital Man> SGR Mouse button (0x00) PRESS reported at: 45 x 14
6/25 06:41:08p Node 1 <Digital Man> Stuffing hot spot command into keybuf: 'K'
6/25 06:41:08p Node 1 <Digital Man> append key into keybuf: 4B (K)
6/25 06:41:08p Node 1 <Digital Man> Key = K
6/25 06:41:08p Node 1 <Digital Man> SGR Mouse button (0x00) RELEASE reported at: 45 x 14
6/25 06:41:08p Node 1 <Digital Man> Eating SGR mouse report: 'ESC[<0;46;15m'
6/25 06:41:10p Node 1 <Digital Man> SGR Mouse button (0x00) PRESS reported at: 45 x 15
6/25 06:41:10p Node 1 <Digital Man> Stuffing hot spot command into keybuf: 'Q'
6/25 06:41:10p Node 1 <Digital Man> append key into keybuf: 51 (Q)
6/25 06:41:10p Node 1 <Digital Man> Key = Q
6/25 06:41:10p Node 1 <Digital Man> SGR Mouse button (0x00) RELEASE reported at: 45 x 15
6/25 06:41:10p Node 1 <Digital Man> Eating SGR mouse report: 'ESC[<0;46;16m'
```

So I suspect there is something else going with your command shell(s) or custom/3rd-party module(s) that is triggering this issue.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/issues/412#note_2647

You don't have a menu option to run an external program which is why it works for you.

cmdkey J
exec "?../xtrn/DDAreaChoosers/DDMsgAreaChooser.js"
end_cmd


Jun 25 22:34:15 bbs synchronet: term Node 1 <Nelgin> SGR Mouse button (0x00) PRESS reported at: 31 x 10
Jun 25 22:34:15 bbs synchronet: term Node 1 <Nelgin> Stuffing hot spot command into keybuf: 'J'
Jun 25 22:34:15 bbs synchronet: term Node 1 <Nelgin> append key into keybuf: 4A (J)
Jun 25 22:34:15 bbs synchronet: term Node 1 <Nelgin> SGR Mouse button (0x00) RELEASE reported at: 31 x 10
Jun 25 22:34:15 bbs synchronet: term Node 1 <Nelgin> Eating SGR mouse report: 'ESC[<0;32;11m'

It's still not "eating" the characters.

From IRC:

[05:09] <nelgin> Jun 25 05:05:23 bbs synchronet: term Node 2 <Nelgin> SGR Mouse button-click (0x00) reported at: 6 x 11
[05:09] <nelgin> Jun 25 05:05:23 bbs synchronet: term Node 2 <Nelgin> Eating SGR mouse report: 'ESC[<0;7;12m'
[05:09] <nelgin> ---
[05:09] <nelgin> When clicking on something that executes an external program: [05:10] <nelgin> Jun 25 05:07:03 bbs synchronet: term Node 2 <Nelgin> append key into keybuf: 4A (J)
[05:10] <nelgin> Jun 25 05:07:03 bbs synchronet: term Node 2 <Nelgin> Executing external: ?../xtrn/DDAreaChoosers/DDMsgAreaChooser.js
[05:10] <nelgin> Jun 25 05:07:03 bbs synchronet: term Node 2 <Nelgin> insert key into keybuf: 3C (<)
[05:10] <nelgin> Jun 25 05:07:03 bbs synchronet: term Node 2 <Nelgin> insert key into keybuf: 5B ([)
[05:10] <nelgin> Jun 25 05:07:03 bbs synchronet: term Node 2 <Nelgin> insert key into keybuf: 30 (0)
[05:10] <nelgin> All that junk is sent to the external program. Whatever you to do "eat SGR mouse reports" needs to be done before executing an external program, it seems.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/issues/412#note_2654

The "junk" here is a mouse button "release" event.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/issues/412#note_2656

So I suspect the "external program" is doing something (e.g. disabling sbbs's mouse support), so the mouse button release event isn't getting "eaten".

As an experiment, try this change in inkey.cpp:
from this:
```
if(button == 0 && ch == 'M') { // Left-button press
```

to this:
```
if(button == 0 && ch == 'm') { // Left-button release
```

With that change, only mouse button *releases* will be counted as as hotspot-clicks. Let me know how that works for you.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/issues/412#note_2657

This change fixes the issue in the mail reader and chooser so that's progress.

It also completely disables the mouse in the avatar chooser, but again, no "junk".

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/issues/412#note_2660

After this change, the mouse in avatar chooser continues to work for me.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/issues/412#note_2661

Not here. I checked the logfiles and it's not registering any clicks while in the avatar chooser.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

close https://gitlab.synchro.net/main/sbbs/-/issues/412

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net