1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/sbbs3/netmail.cpp

    From rswindell@VERT to CVS commit on Thu Apr 23 04:23:42 2020
    src/sbbs3 netmail.cpp 1.63 1.64
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv25869

    Modified Files:
    netmail.cpp
    Log Message:
    Refactor inetmail() to use convenience functions smb_open_sub() and savemsg() to eliminate a lot of copy-pasta.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Fri Apr 24 06:31:04 2020
    src/sbbs3 netmail.cpp 1.65 1.66
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/home/rswindell/sbbs/src/sbbs3

    Modified Files:
    netmail.cpp
    Log Message:
    Resolve gcc warning: comparison between signed and unsigned integer expressions



    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Fri Apr 24 06:42:51 2020
    src/sbbs3 netmail.cpp 1.66 1.67
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv16580

    Modified Files:
    netmail.cpp
    Log Message:
    Remove the legacy comments/code from netmail().


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Mon Apr 27 23:33:15 2020
    src/sbbs3 netmail.cpp 1.67 1.68
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv3242

    Modified Files:
    netmail.cpp
    Log Message:
    When creating an FTN netmail message, set the "LOCAL" attribute flag in
    the net-attributes header fields.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Thu Apr 30 17:10:07 2020
    src/sbbs3 netmail.cpp 1.68 1.69
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv14787

    Modified Files:
    netmail.cpp
    Log Message:
    Set the "LOCAL" network-attribute on locally-created Internet email messages (no use currently, but seems prudent).
    Set the KILLSENT network attribute for created Internet email messages when enabled in SCFG->Networks->Internet (new option).


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Sun Sep 13 08:02:50 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/0cc5b5946923e348a671d014
    Modified Files:
    src/sbbs3/netmail.cpp
    Log Message:
    Resolve gcc warning: enumeration value `NET_NONE' not handled in switch

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Thu Dec 10 07:37:08 2020
    https://gitlab.synchro.net/main/sbbs/-/commit/bc6cddb0a725985e819e1fe5
    Modified Files:
    src/sbbs3/netmail.cpp
    Log Message:
    Address GCC warning

    `%s' directive writing up to 255 bytes into a region of size between 103 and 128
    reported by Nelgin.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Mon Feb 15 07:17:15 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/9683b9d22c3c7e2cce1b29b2
    Modified Files:
    src/sbbs3/netmail.cpp
    Log Message:
    Handle filelength() failure gracefully

    Addresses Coverity's NEGATIVE_RETURNS bug-checker issue.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Mon Feb 15 09:12:32 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/c037303847e32cd0db195573
    Modified Files:
    src/sbbs3/netmail.cpp
    Log Message:
    Address gcc warning: comparison of integer expressions of different signedness

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Tue Feb 16 03:31:37 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/d19237210fb6279fba625ce8
    Modified Files:
    src/sbbs3/netmail.cpp
    Log Message:
    Address gcc warning: comparison of integer expressions of different signedness

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Wed Mar 2 19:25:51 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/bea7394e614931fc63961086
    Modified Files:
    src/sbbs3/netmail.cpp
    Log Message:
    Detect smb_[f]allocdat() failures in qnetmail()

    CID 319140

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Wed Mar 2 19:25:51 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/cb9a3753fee63c37e50677f3
    Modified Files:
    src/sbbs3/netmail.cpp
    Log Message:
    Fix issue in previous commit: no need to free what wasn't allocated

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sun Mar 13 06:28:10 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/7e1c3c3d3944249c05686250
    Modified Files:
    src/sbbs3/netmail.cpp
    Log Message:
    Fix CID 319119: Unchecked return value from library

    Actually probably doesn't fix it, but what'evs

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Fri Jun 10 22:54:03 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/121ce679be01b8f4fa5131c2
    Modified Files:
    src/sbbs3/netmail.cpp
    Log Message:
    Safe string formatting of fido netmail time header field

    Suppresses GCC warning. I suppose some of these fields could be more digits than expected.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Fri Dec 29 17:10:28 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/8f54b5ce31565dd8031982b0
    Modified Files:
    src/sbbs3/netmail.cpp
    Log Message:
    Fix error path memory leak (unlikely, but not impossible)

    CID 462234

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Thu Jan 22 15:08:08 2026
    https://gitlab.synchro.net/main/sbbs/-/commit/4aa2274c97e8e79e46d3d757
    Modified Files:
    src/sbbs3/netmail.cpp
    Log Message:
    Refuse to send netmail to our own addresses

    as Keyop pointed out, at least for FTN netmail, this would just create an orphaned .msg file in the netmail directory: SBBSecho won't import it (by default) because it was created locally and won't export it to a packet because you don't have a link to yourself. Internet email would just loop back
    (if everything's configured and working) and sending to your own QWK-ID would've already been rejected. Hopefully nobody is depending on the Internet e-mail loopback functionality.

    There were sysop exemptions for when the "Allow Sending of ..." settings in SCFG->Networks->Internet E-mail and FidoNet were set to "No", but now those
    are defeated (if they're set to, even the sysop won't be able to send e-mail/ NetMail). If we really want to control *who* can send netmail, we should
    be using ARS for that rather than a toggle that just (confusingly) doesn't apply to the sysop(s).

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Wed Feb 11 22:20:06 2026
    https://gitlab.synchro.net/main/sbbs/-/commit/f0545836096d44c51b14bdb1
    Modified Files:
    src/sbbs3/netmail.cpp
    Log Message:
    Redirect netmail sent to local user's netmail address to personal inbox

    If a user attempts to send netmail to a netmail address that is invalid (because it's local) yet there's a user with that address configured as their netmail address (in the userbase), send the message as an email to that user. Rather than just failing with error "Invalid NetMail address: <name@address>"

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Thu Feb 19 22:53:59 2026
    https://gitlab.synchro.net/main/sbbs/-/commit/002aa81ea984222fb9e48845
    Modified Files:
    src/sbbs3/netmail.cpp
    Log Message:
    Fix bug: wrong smb_t* passed in here

    Would cause a NULL fp to try to be used to quote the message text

    Introduced in commit f0545836096d44

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net