Forum: The Horizon BBS

comReadBuf() supports an infinite timeout (0)

From Deuc¿@VERT to GitLab note in main/sbbs on Mon Jan 24 14:37:42 2022

https://gitlab.synchro.net/main/sbbs/-/commit/0b8517e11ce52702b4c56e2926990ae456dc23f6#note_2223

This seems very dangerous since it will continue block across a disconnection/new connection. Is that the intended use case?

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

From Rob Swindell@VERT to GitLab note in main/sbbs on Mon Jan 24 15:18:58 2022

https://gitlab.synchro.net/main/sbbs/-/commit/0b8517e11ce52702b4c56e2926990ae456dc23f6#note_2224

Yeah, I mentioned the risks to the requester (Nelgin) and he tested and was okay with the change: upon disconnect, the modem is always sending *something* to the application (SexPOTS), so it always aborts this loop. Still, I made the default timeout non-zero (60 seconds).

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

From Deuc¿@VERT to GitLab note in main/sbbs on Mon Jan 24 15:55:48 2022

https://gitlab.synchro.net/main/sbbs/-/commit/0b8517e11ce52702b4c56e2926990ae456dc23f6#note_2225

While that works fine for his modem usage, I don't understand why he needs more than the 68 years allowed by the timeout value.

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

From Deuc¿@VERT to GitLab note in main/sbbs on Mon Jan 24 16:02:25 2022

https://gitlab.synchro.net/main/sbbs/-/commit/0b8517e11ce52702b4c56e2926990ae456dc23f6#note_2226

I'm also not sure why his ask is important enough to potentially break existing consumers and/or add a special-case value.

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

From Deuc¿@VERT to GitLab note in main/sbbs on Mon Jan 24 16:04:16 2022

https://gitlab.synchro.net/main/sbbs/-/commit/0b8517e11ce52702b4c56e2926990ae456dc23f6#note_2227

I think passing INT_MAX for infinite timeout would be *much* better than zero.

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

From Rob Swindell@VERT to GitLab note in main/sbbs on Mon Jan 24 17:06:07 2022

https://gitlab.synchro.net/main/sbbs/-/commit/0b8517e11ce52702b4c56e2926990ae456dc23f6#note_2228

I did search and could not locate any caller of this function with a timeout parameter value of 0. Seemed like a safe-enough change but using INT_MAX or INT_MIN is fine too.

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

From Nelgin@VERT/EOTLBBS to Deuc¿ on Tue Jan 25 00:42:01 2022

On Mon, 24 Jan 2022 15:55:48 -0800
"Deuc_" <deuc_@VERT> wrote:

https://gitlab.synchro.net/main/sbbs/-/commit/0b8517e11ce52702b4c56e2926990ae456dc23f6#note_2225

While that works fine for his modem usage, I don't understand why he
needs more than the 68 years allowed by the timeout value.

If someone had told me I cannot have an invite timeout but if you set
it to 0 then it'll be 68 years, I'd have been fine with that.
--
End Of The Line BBS - Plano, TX
telnet endofthelinebbs.com 23
---
� Synchronet � End Of The Line BBS - endofthelinebbs.com

Who's Online
Recent Visitors
- Chewbacca
  Thu May 8 19:11:35 2025
  from Bhc, Az via Telnet
- Chewbacca
  Thu May 8 18:27:46 2025
  from Bhc, Az via Telnet
- NJMCdirect
  Thu May 8 04:46:43 2025
  from florida via HTTPS
- STD267562
  Thu May 8 03:26:17 2025
  from Manchester via HTTPS

System Info

Sysop:	Chris Crash
Location:	Huntington Beach, CA.
Users:	611
Nodes:	8 (0 / 8)
Uptime:	33:20:53
Calls:	10,849
Files:	5
Messages:	505,106